cf-charmers team mailing list archive

[Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>]

LGTM

Thanks, I would consider just using config. or common. for the import
namespace of constants


https://codereview.appspot.com/91450049/diff/1/hooks/install
File hooks/install (right):

https://codereview.appspot.com/91450049/diff/1/hooks/install#newcode13
hooks/install:13: import config as uaa_config
just config. is fine again

https://codereview.appspot.com/91450049/diff/1/hooks/install#newcode43
hooks/install:43: 'sqlite-jdbc-3.7.2.jar'])
Hopefully we can drop this once we move to mysql

https://codereview.appspot.com/91450049/

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-uaa/refactor/+merge/219918
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-uaa/refactor into lp:~cf-charmers/charms/trusty/cf-uaa/trunk.