← Back to team overview

cf-charmers team mailing list archive

Re: Refactored to use refactored charm-helpers (issue 96360049)

 

I think that it would be better to rename gorouter.conf upstart job to
cf-gorouter.conf or cf-go-router.conf (I mean this change
https://codereview.appspot.com/96360049/patch/20001/30021),
just to do it in the same way with other charms.




On 21 May 2014 01:03, Cory Johns <cory.johns@xxxxxxxxxxxxx> wrote:

> *** Submitted:
>
> Refactored to use refactored charm-helpers
>
> R=benjamin.saller
> CC=
> https://codereview.appspot.com/96360049
>
>
> https://codereview.appspot.com/96360049/
>
> --
>
> https://code.launchpad.net/~johnsca/charms/trusty/cf-go-router/refactor/+merge/219914
> Your team Cloud Foundry Charmers is requested to review the proposed merge
> of lp:~johnsca/charms/trusty/cf-go-router/refactor into
> lp:~cf-charmers/charms/trusty/cf-go-router/trunk.
>
> --
> Mailing list: https://launchpad.net/~cf-charmers
> Post to     : cf-charmers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~cf-charmers
> More help   : https://help.launchpad.net/ListHelp
>

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-go-router/refactor/+merge/219914
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-go-router/refactor into lp:~cf-charmers/charms/trusty/cf-go-router/trunk.


References