cf-charmers team mailing list archive
-
cf-charmers team
-
Mailing list archive
-
Message #00238
Re: Fixed relation ordering issue (issue 100680044)
Thanks I like this, I'll approve it pending the answer to the one
question
https://codereview.appspot.com/100680044/diff/1/hooks/hooks.py
File hooks/hooks.py (right):
https://codereview.appspot.com/100680044/diff/1/hooks/hooks.py#newcode18
hooks/hooks.py:18: def register():
why the containing method? it seems fine to register with hooks on
import
https://codereview.appspot.com/100680044/diff/1/hooks/hooks.py#newcode41
hooks/hooks.py:41:
'router-relation-changed')(services.reconfigure_services)
The other pattern is more familiar but I think we could get people used
to this and it has the advantage of being very concise. :)
https://codereview.appspot.com/100680044/
--
https://code.launchpad.net/~johnsca/charms/trusty/cf-cloud-controller/services-callback-fu/+merge/220741
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-cloud-controller/services-callback-fu into lp:~cf-charmers/charms/trusty/cf-cloud-controller/trunk.
References