cf-charmers team mailing list archive

[Alexander Lomov <lomov.as@xxxxxxxxx>]

Hey, Cory.

I've just found a bug after redeploying CF with juju. Currently we use
trunk branch for deployment, because of strange behavior of juju-deployer
[1].

After DEA charm is installed it has only *cf-dea* and
*cf-dea-logging-agent* upstart
jobs exist. You can see where the issue is if you take a look on how
services are declared in DEA's hook.py [2] and what UpstartService is
really doing when setting target [3]. I think you should use source file
name here as a default name to avoid targeting all templates to one file.

I believe tests can really help to avoid such errors.


*Links:*
[1] https://lists.launchpad.net/cf-charmers/msg00244.html
[2]
http://bazaar.launchpad.net/~cf-charmers/charms/trusty/cf-dea/trunk/view/head:/hooks/hooks.py#L27
[3]
http://bazaar.launchpad.net/~cf-charmers/charm-helpers/cloud-foundry/view/head:/charmhelpers/core/services.py#L78


Thank you,
Alex L.