cf-charmers team mailing list archive

[Whit Morriss <whit.morriss@xxxxxxxxxxxxx>]

LGTM. nice and concise.


https://codereview.appspot.com/100680044/diff/20001/hooks/charmhelpers/core/services.py
File hooks/charmhelpers/core/services.py (left):

https://codereview.appspot.com/100680044/diff/20001/hooks/charmhelpers/core/services.py#oldcode5
hooks/charmhelpers/core/services.py:5: SERVICES = {}
As discussed with Cory: we are abusing module scope and globals to
emulate object behavior.  I feel the code will age and extend better if
we sacrificed a tiny bit of api convenience and used idiomatic python
classes here.

https://codereview.appspot.com/100680044/

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-cloud-controller/services-callback-fu/+merge/220741
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-cloud-controller/services-callback-fu into lp:~cf-charmers/charms/trusty/cf-cloud-controller/trunk.