cf-charmers team mailing list archive

[Cory Johns <cory.johns@xxxxxxxxxxxxx>]

On 2014/06/02 18:32:47, benjamin.saller wrote:
> LGTM thanks.

> I'm a little wary of depending on charms outside of our namespace, but
we can
> change this once you merge up your branch. I'd suggest pushing hm9000
into our
> namespace and then updating the reference here before landing. As for
etcd, I
> don't think that makes sense to fork, but we should push to get it
into the
> store sooner than later.

Yeah, the bundle changes were just to show what would need to be added
for the HM9k charm, and for testing purposes.  I fully expected it to
change to cf-charmers / store links before merging this, as I tried to
convey in the review description.

I used hazmat's etcd since there wasn't one ready in cf-charmers, but
there's a proposed one using the services framework that we can evaluate
as well.  But hazmat's version works currently, so I'm ok just getting
that into the store.

https://codereview.appspot.com/105760044/

-- 
https://code.launchpad.net/~johnsca/charms/bundles/cloudfoundry/hm9k/+merge/221772
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/bundles/cloudfoundry/hm9k into lp:~cf-charmers/charms/bundles/cloudfoundry/bundle.