cf-charmers team mailing list archive

Thread
Date

Re: Finished charm using services framework (issue 104820043)

To: Cory Johns <cory.johns@xxxxxxxxxxxxx>
From: Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>
Date: Fri, 06 Jun 2014 16:45:39 -0000
In-reply-to: <20140602174921.1735.65770.launchpad@ackee.canonical.com>
Reply-to: mp+221770@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

This LGTM,+1


https://codereview.appspot.com/104820043/diff/40001/templates/hm9000.json
File templates/hm9000.json (right):

https://codereview.appspot.com/104820043/diff/40001/templates/hm9000.json#newcode14
templates/hm9000.json:14: {% for unit in etcd -%}
nice, thanks

https://codereview.appspot.com/104820043/

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-hm9000/services/+merge/221770
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-hm9000/services into lp:~cf-charmers/charms/trusty/cf-hm9000/trunk.

References

[Merge] lp:~johnsca/charms/trusty/cf-hm9000/services into lp:~cf-charmers/charms/trusty/cf-hm9000/trunk
From: Cory Johns, 2014-06-02