cf-charmers team mailing list archive
-
cf-charmers team
-
Mailing list archive
-
Message #00356
Re: Refactored RelationContext multi-unit support (issue 96680043)
+1 LTGM, thanks for talking through that issue.
https://codereview.appspot.com/96680043/diff/120001/charmhelpers/core/services.py
File charmhelpers/core/services.py (right):
https://codereview.appspot.com/96680043/diff/120001/charmhelpers/core/services.py#newcode272
charmhelpers/core/services.py:272: set of data came from, you'll need to
extend this class to preserve
Great, thanks
https://codereview.appspot.com/96680043/
--
https://code.launchpad.net/~johnsca/charm-helpers/multi-unit/+merge/221801
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charm-helpers/multi-unit into lp:~cf-charmers/charm-helpers/cloud-foundry.
References