← Back to team overview

cf-charmers team mailing list archive

Resolve port conflicts in cf-go-router (issue 103270043)

 

Reviewers: mp+222671_code.launchpad.net,

Message:
Please take a look.

Description:
Resolve port conflicts in cf-go-router



https://code.launchpad.net/~johnsca/charms/trusty/cf-go-router/port-conflicts/+merge/222671

(do not edit description out of merge proposal)


Please review this at https://codereview.appspot.com/103270043/

Affected files (+134, -75 lines):
   A [revision details]
   M config.yaml
   M hooks/charmhelpers/contrib/cloudfoundry/contexts.py
   M hooks/charmhelpers/core/services.py
   M hooks/config.py
   A hooks/logrouter-relation-changed
   M hooks/tests/test_hooks.py
   M metadata.yaml
   M templates/gorouter.yml



-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-go-router/port-conflicts/+merge/222671
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-go-router/port-conflicts into lp:~cf-charmers/charms/trusty/cf-go-router/trunk.


References