cf-charmers team mailing list archive

Thread
Date

Re: Bundle changes to resolve port conflicts (issue 106920044 by johnsca@xxxxxxxxx)

To: Cory Johns <cory.johns@xxxxxxxxxxxxx>
From: Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>
Date: Wed, 11 Jun 2014 22:45:37 -0000
In-reply-to: <20140610155620.17470.14490.launchpad@ackee.canonical.com>
Reply-to: mp+222672@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

LGTM with minors


https://codereview.appspot.com/106920044/diff/1/bundles.yaml
File bundles.yaml (right):

https://codereview.appspot.com/106920044/diff/1/bundles.yaml#newcode81
bundles.yaml:81: outgoing_port: 8082
the options come back out

thanks for including the hm/etcd

https://codereview.appspot.com/106920044/

-- 
https://code.launchpad.net/~johnsca/charms/bundles/cloudfoundry/port-conflicts/+merge/222672
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/bundles/cloudfoundry/port-conflicts into lp:~cf-charmers/charms/bundles/cloudfoundry/bundle.

References

[Merge] lp:~johnsca/charms/bundles/cloudfoundry/port-conflicts into lp:~cf-charmers/charms/bundles/cloudfoundry/bundle
From: Cory Johns, 2014-06-10