cf-charmers team mailing list archive

[Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>]

LGTM with minors

I think there are still conflict here on some of the port numbers. If my
read of this is wrong feel free to merge, otherwise change the defaults
and you can land it.

Thanks


https://codereview.appspot.com/105880043/diff/40001/hooks/config.py
File hooks/config.py (right):

https://codereview.appspot.com/105880043/diff/40001/hooks/config.py#newcode47
hooks/config.py:47: 'varz_port': 8888,
Won't these ports still conflict with loggregator/logrouter in the
single machine case? don't we need to change the defaults here? I think
varz is the same for both.

Additionally I'd defined these up top so they don't have to be changed
in the relation set at the same time.

https://codereview.appspot.com/105880043/

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-logrouter/port-conflicts/+merge/222676
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-logrouter/port-conflicts into lp:~cf-charmers/charms/trusty/cf-logrouter/trunk.