cf-charmers team mailing list archive

Thread
Date

Re: [Merge] lp:~johnsca/charms/trusty/cloudfoundry/catchup into lp:~cf-charmers/charms/trusty/cloudfoundry/trunk

To: Cory Johns <cory.johns@xxxxxxxxxxxxx>
From: Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>
Date: Wed, 10 Dec 2014 16:11:43 -0000
In-reply-to: <20141209213720.29599.19491.launchpad@ackee.canonical.com>
Reply-to: mp+244226@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

These changes LGTM. Its nice that you found the dangling reference issue with placement and the clean up on interface types, like http->login. 

I'd like to hold off landing this until we've identified the remaining issue with CATs, even if we can't fix that one remaining test run today I'd like some clarity as to why. If it works on a fresh run this morning its most likely a GC issue and we'll need to address that separately.

Thanks 
-- 
https://code.launchpad.net/~johnsca/charms/trusty/cloudfoundry/catchup/+merge/244226
Your team Cloud Foundry Charmers is subscribed to branch lp:~cf-charmers/charms/trusty/cloudfoundry/trunk.

References

[Merge] lp:~johnsca/charms/trusty/cloudfoundry/catchup into lp:~cf-charmers/charms/trusty/cloudfoundry/trunk
From: Cory Johns, 2014-12-09