← Back to team overview

checkbox-dev team mailing list archive

[PATCH 07/13] plainbox:providers: add DummyProvider1.locale_dir

 

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@xxxxxxxxxxxxx>
---
 plainbox/plainbox/impl/providers/v1.py             | 4 ++++
 plainbox/plainbox/impl/secure/providers/test_v1.py | 7 -------
 plainbox/plainbox/impl/secure/providers/v1.py      | 7 -------
 3 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/plainbox/plainbox/impl/providers/v1.py b/plainbox/plainbox/impl/providers/v1.py
index f5ac760..203049d 100644
--- a/plainbox/plainbox/impl/providers/v1.py
+++ b/plainbox/plainbox/impl/providers/v1.py
@@ -99,6 +99,10 @@ class DummyProvider1(IProvider1, IProviderBackend1):
     def whitelists_dir(self):
         return self._extras.get("whitelists_dir")
 
+    @property
+    def locale_dir(self):
+        return self._extras.get("locale_dir")
+
     def secure(self):
         return False
 
diff --git a/plainbox/plainbox/impl/secure/providers/test_v1.py b/plainbox/plainbox/impl/secure/providers/test_v1.py
index ce45665..3aa2e95 100644
--- a/plainbox/plainbox/impl/secure/providers/test_v1.py
+++ b/plainbox/plainbox/impl/secure/providers/test_v1.py
@@ -558,13 +558,6 @@ class Provider1Tests(TestCase):
         """
         self.assertEqual(self.provider.locale_dir, self.LOCALE_DIR)
 
-    def test_locale_dir_rw(self):
-        """
-        Verify that Provider1.locale_dir attribute is can be reset
-        """
-        self.provider.locale_dir = "new-locale-dir"
-        self.assertEqual(self.provider.locale_dir, "new-locale-dir")
-
     def test_CHECKBOX_SHARE(self):
         """
         Verify that Provider1.CHECKBOX_SHARE is always equal to base_dir
diff --git a/plainbox/plainbox/impl/secure/providers/v1.py b/plainbox/plainbox/impl/secure/providers/v1.py
index 7d6777b..c0366f4 100644
--- a/plainbox/plainbox/impl/secure/providers/v1.py
+++ b/plainbox/plainbox/impl/secure/providers/v1.py
@@ -239,16 +239,9 @@ class Provider1(IProvider1, IProviderBackend1):
         absolute path of the directory with locale data
 
         The value is applicable as argument bindtextdomain()
-
-        The returned value may either be a custom directory, assigned to this
-        property explicitly or None (default)
         """
         return self._locale_dir
 
-    @locale_dir.setter
-    def locale_dir(self, new_value):
-        self._locale_dir = new_value
-
     @property
     def CHECKBOX_SHARE(self):
         """
-- 
1.9.0



References