← Back to team overview

checkbox-dev team mailing list archive

Re: Action required: if you push branches for review please read this

 

We can do interesting things pre-commit or pre-push hooks but we'd have to
adopt git. With bzr that's rather ugly/painful.

Thanks
ZK


On Wed, May 14, 2014 at 7:49 PM, Zygmunt Krynicki <
zygmunt.krynicki@xxxxxxxxxxxxx> wrote:

> There are comments in that script with links to the bug report.
>
>
> On Wed, May 14, 2014 at 4:53 PM, Jeffrey Lane <jeffrey.lane@xxxxxxxxxxxxx>wrote:
>
>> On Wed, May 14, 2014 at 10:21 AM, Zygmunt Krynicki
>> <zygmunt.krynicki@xxxxxxxxxxxxx> wrote:
>> > ./support/fix-LP1319297
>>
>> Seems a bit non-descriptive.  will you remember in 8 months what that
>> was?  more importantly, will any new contributors know at all what
>> LP1319279 is?
>>
>> Last question, are there other things a person should run?
>>
>> For example, maybe a script called "prepare-upload" or something that
>> does at least the following:
>>
>> runs your fix-LP1319297
>> runs setup test to run all unit tests
>> runs anything else that would ensure a better branch upload.
>>
>> Then the process could be as generic as
>>
>> bzr commit -m "FOO"
>> ./support/prepare-upload
>> bzr push BRANCH
>>
>> Just a thought in any case... not sure how that would work across the
>> multiple code trees inside of lp:checkbox so feel free to ignore it.
>>
>>
>>
>> --
>> "Entropy isn't what it used to be."
>>
>> Jeff Lane - Server Certification Team Lead, Tools Developer, Warrior
>> Poet, Lover of Pie
>> Ubuntu Ham: W4KDH
>> Freenode IRC: bladernr or bladernr_
>> gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417  C466 4ABD 3635 3A14 B2DD
>>
>> --
>> Mailing list: https://launchpad.net/~checkbox-dev
>> Post to     : checkbox-dev@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~checkbox-dev
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>

References