clearcorp team mailing list archive

[noreply@xxxxxxxxxxxxx]

Merge authors:
  Stefan Rijnhart (Therp) (stefan-therp)
Related merge proposals:
  https://code.launchpad.net/~therp-nl/banking-addons/ab6.1-lp1085113-take_first_of_two_partners_with_same_name/+merge/137996
  proposed by: Stefan Rijnhart (Therp) (stefan-therp)
  review: Resubmit - Stefan Rijnhart (Therp) (stefan-therp)
  review: Approve - Guewen Baconnier @ Camptocamp (gbaconnier-c2c)
------------------------------------------------------------
revno: 141 [merge]
author: Stefan Rijnhart (Therp)
committer: Guewen Baconnier @ Camptocamp <guewen.baconnier@xxxxxxxxxxxxxx>
branch nick: banking-addons
timestamp: Wed 2012-12-05 09:21:23 +0100
message:
  [FIX] Import fails if two partners exist with same name as on the statement
modified:
  account_banking/wizard/banktools.py


--
lp:banking-addons
https://code.launchpad.net/~banking-addons-team/banking-addons/6.1

Your team CLEARCORP development team is subscribed to branch lp:banking-addons.
To unsubscribe from this branch go to https://code.launchpad.net/~banking-addons-team/banking-addons/6.1/+edit-subscription

=== modified file 'account_banking/wizard/banktools.py'
--- account_banking/wizard/banktools.py	2012-06-26 11:17:32 +0000
+++ account_banking/wizard/banktools.py	2012-12-05 07:22:19 +0000
@@ -125,6 +125,9 @@
                           country_code, log):
     '''
     Get or create the partner belonging to the account holders name <name>
+
+    If multiple partners are found with the same name, select the first and
+    add a warning to the import log.
     '''
     partner_obj = pool.get('res.partner')
     partner_ids = partner_obj.search(cursor, uid, [('name', 'ilike', name)])
@@ -177,13 +180,12 @@
                 'country_id': country_id,
             })],
         ))
-    elif len(partner_ids) > 1:
-        log.append(
-            _('More then one possible match found for partner with name %(name)s')
-            % {'name': name}
-        )
-        return False
     else:
+        if len(partner_ids) > 1:
+            log.append(
+                _('More than one possible match found for partner with name %(name)s')
+                % {'name': name}
+                )
         partner_id = partner_ids[0]
     return partner_id