← Back to team overview

clicompanion-devs team mailing list archive

Current default command library contains incorrect definitions

 

Apparently, the set of commands currently included by default as a
command library has never been tested (on Ubuntu, never mind on Debian).

Here are three problems I found in a few quick tests:

(1) ps auxww | grep @

This prompts for a process (really a process ID).  It has two problems:

(1A) If you provide the number 1 as a process id, you get info on all
processes with a 1 anywhere in their output from ps u, rather than just
the info for PID 1.

(1B) It is inefficient and poor practice to output way more information
that you need, and then use a second process to select from it, unless
you have no other option.  The way to tell ps to output info for the
process with PID 1 is -p 1 -- why was this not used?

(2) cp ?

This can never work.  cp needs source and destination as mandatory
parameters, so prompting for only one will always fail.

(3) mv ?

This, like cp, can never work.  mv needs source and destination as
mandatory parameters, so prompting for only one will always fail.

Could I suggest that someone actually tests all of the commands in the
default library, and fixes all that are broken, before 1.1 is released?
 Trying out commands from the supplied list, and being unable to get
them to work, could be rather confusing and disheartening to the
newcomers clicompanion is trying to help.

Jonathan