clicompanion-devs team mailing list archive

[David Caro Estévez <david.caro.estevez@xxxxxxxxx>]

Hi,
yes, I did.

I think also that we must write a little document calked 'programming
gudelines' to have some basic rules to follow (instead of having to read
the whole pep8 document) and avoid having to rewrite code just because it's
using tabs instead of spaces.

Also I should have documented a little the code about using events (mea
culpa), so everyone could easily understand what events are implementes and
how to use them.

As soon as I have enough time I will try to address this issues, sorry.

David
El 21/05/2012 01:03, "Matthew Byers" <faintstlsaint@xxxxxxxxx> escribió:

> I assuming that dcaro reviewed the branch and states it needs fixing?
>
> On Sun, May 20, 2012 at 2:47 AM, bdfhjk <bdfhjk@xxxxxxxxx> wrote:
>
>> Thank You!
>>
>>
>> 2012/5/20 Matthew Byers <faintstlsaint@xxxxxxxxx>
>>
>>> Strange. May have fell between the cracks. It will be reviewed today
>>>  On May 19, 2012 4:26 AM, "bdfhjk" <bdfhjk@xxxxxxxxx> wrote:
>>>
>>>>  Hello,
>>>>
>>>> I remind about my review request[1], it last 19 days.
>>>>
>>>> Thanks in advance,
>>>> Marek
>>>>
>>>> [1]https://code.launchpad.net/~bdfhjk/clicompanion/setupscript-2
>>>>
>>>> --
>>>> Mailing list: https://launchpad.net/~clicompanion-devs
>>>> Post to     : clicompanion-devs@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~clicompanion-devs
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>
>
>
> --
> God Bless
>
> --
> Mailing list: https://launchpad.net/~clicompanion-devs
> Post to     : clicompanion-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~clicompanion-devs
> More help   : https://help.launchpad.net/ListHelp
>
>