cloud-init-dev team mailing list archive

[Andy Grimm <agrimm@xxxxxxxxxxxxxx>]

Andy Grimm has proposed merging lp:~agrimm/cloud-init/trunk-lp1050962 into lp:cloud-init.

Requested reviews:
  cloud init development team (cloud-init-dev)
Related bugs:
  Bug #1050962 in cloud-init: "creation of hostname based on IP is broken"
  https://bugs.launchpad.net/cloud-init/+bug/1050962

For more details, see:
https://code.launchpad.net/~agrimm/cloud-init/trunk-lp1050962/+merge/124456

Fixes 1050962
-- 
https://code.launchpad.net/~agrimm/cloud-init/trunk-lp1050962/+merge/124456
Your team cloud init development team is requested to review the proposed merge of lp:~agrimm/cloud-init/trunk-lp1050962 into lp:cloud-init.

=== modified file 'cloudinit/sources/__init__.py'
--- cloudinit/sources/__init__.py	2012-08-28 03:51:00 +0000
+++ cloudinit/sources/__init__.py	2012-09-14 15:52:41 +0000
@@ -173,7 +173,7 @@
             # make up a hostname (LP: #475354) in format ip-xx.xx.xx.xx
             lhost = self.metadata['local-hostname']
             if util.is_ipv4(lhost):
-                toks = "ip-%s" % lhost.replace(".", "-")
+                toks = [ "ip-%s" % lhost.replace(".", "-") ]
             else:
                 toks = lhost.split(".")