← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] lp:~harm-o/cloud-init/freebsd into lp:cloud-init

 

> Great start!
Thanks :)
I've taken your comments plus some notes from #cloud-init and did some additions and changes.

>  - wow, didn't know uptime had to be done with ctypes, is there no other way?
> is the `uptime` command pretty standard? for the logexc(LOG, "Unable to read
> uptime") can we also add in the method (similar to the above mount method); so
> that if it fails we can easily know which method was tried, maybe we could
> consider using https://pypi.python.org/pypi/uptime which seems to be more
> platform agnoistic (and simpler to use) - http://pythonhosted.org/uptime
> /#supported-platforms

While a pure python module sure would look (a lot) better, it would impose yet another dependency to merely cover just a tiny thing - one thats already in the codebase aswell. I'm definately not against this, just wondering on what the project's thought are about imports in general?

Your ideas about putting more in parsers/ seems nice, I'll see if I can make that work (though, all in good time).

Regarding Cloudbase, I strongly agree with leaving that to do Windows and pulling BSD on board the cloud-init train. It just makes more sense.
-- 
https://code.launchpad.net/~harm-o/cloud-init/freebsd/+merge/198130
Your team cloud init development team is requested to review the proposed merge of lp:~harm-o/cloud-init/freebsd into lp:cloud-init.


References