← Back to team overview

cloud-init-dev team mailing list archive

[Merge] lp:~harlowja/cloud-init/mini-os-fixes into lp:cloud-init

 

Joshua Harlow has proposed merging lp:~harlowja/cloud-init/mini-os-fixes into lp:cloud-init.

Requested reviews:
  cloud init development team (cloud-init-dev)

For more details, see:
https://code.launchpad.net/~harlowja/cloud-init/mini-os-fixes/+merge/233399

Fixes one tiny issue and logging adjustments with the openstack datasource to reduce noise.
-- 
https://code.launchpad.net/~harlowja/cloud-init/mini-os-fixes/+merge/233399
Your team cloud init development team is requested to review the proposed merge of lp:~harlowja/cloud-init/mini-os-fixes into lp:cloud-init.
=== modified file 'cloudinit/sources/helpers/openstack.py'
--- cloudinit/sources/helpers/openstack.py	2014-08-27 21:03:43 +0000
+++ cloudinit/sources/helpers/openstack.py	2014-09-04 17:36:52 +0000
@@ -163,10 +163,10 @@
 
     def _find_working_version(self, version):
         try:
-            versions_available = self._fetch_available_versions(self)
+            versions_available = self._fetch_available_versions()
         except Exception as e:
-            LOG.warn("Unable to read openstack versions from %s due to: %s",
-                     self.base_path, e)
+            LOG.debug("Unable to read openstack versions from %s due to: %s",
+                      self.base_path, e)
             versions_available = []
 
         search_versions = [version] + list(OS_VERSIONS)
@@ -178,8 +178,8 @@
             break
 
         if selected_version != version:
-            LOG.warn("Version '%s' not available, attempting to use"
-                     " version '%s' instead", version, selected_version)
+            LOG.debug("Version '%s' not available, attempting to use"
+                      " version '%s' instead", version, selected_version)
         return selected_version
 
     def _read_content_path(self, item):
@@ -239,7 +239,8 @@
                     LOG.debug("Failed reading optional path %s due"
                               " to: %s", path, e)
                 else:
-                    LOG.exception("Failed reading mandatory path %s", path)
+                    LOG.debug("Failed reading mandatory path %s due"
+                              " to: %s", path, e)
             else:
                 found = True
             if required and not found:


Follow ups