cloud-init-dev team mailing list archive

[Shraddha Pandhe <shraddha.pandhe@xxxxxxxxx>]

Review: Needs Fixing

Please add a unittest

Diff comments:

> === modified file 'cloudinit/netinfo.py'
> --- cloudinit/netinfo.py	2014-12-01 05:35:38 +0000
> +++ cloudinit/netinfo.py	2015-01-23 16:58:59 +0000
> @@ -136,7 +136,7 @@
>          routes['ipv4'].append(entry)
>  
>      try:
> -        (route_out6, _err6) = util.subp(["netstat", "-A", "inet6", "-n"])
> +        (route_out6, _err6) = util.subp(["netstat", "-A", "inet6", "-rn"])

Thanks for the change Keith! Can you also add a unittest for this?

>      except util.ProcessExecutionError:
>          pass
>      else:
> 


-- 
https://code.launchpad.net/~timbyr/cloud-init/cloud-init/+merge/247449
Your team cloud init development team is requested to review the proposed merge of lp:~timbyr/cloud-init/cloud-init into lp:cloud-init.