← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] lp:~daniel-thewatkins/cloud-init/shim_fixes into lp:cloud-init


Odd_Bloke, it seems maybe the part find_endpoint after 'No endpoint found in DHCP config.' could/should be its own method . and then some tests on it.  maybe 'extract_value_from_leases_key' or something like that.

other thing, is if you're just reading your two test cases that you added, its very difficult to see how they're any different .  since the only difference is in fact the ip address.  at very lease a comment would be good there.
Your team cloud init development team is requested to review the proposed merge of lp:~daniel-thewatkins/cloud-init/shim_fixes into lp:cloud-init.