← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] lp:~edouardb/cloud-init/scaleway-datasource into lp:cloud-init



This looks well done, thanks.
A couple comments

a.) we'll need some unit tests to ensure we dont inadvertently break this.
b.) is there some way (anyway) we can detect if we're on scaleway?  As it is right now, it looks like we're just going to block and retry for the availability of the MD.  That is much less than ideal, and the only current "on by default" datasource thtat does that is EC2 (which only gets that privilege from being first).  Other vendors provide some dmi data or another quick local test.
c.) you'll need to sign the Canonical Contributors License Agreement (http://www.ubuntu.com/legal/contributors)
d.) vendor-data would be nice (and helpful to you as the operator of the cloud.

again, though.  Thanks, it looks really good.
Feel free to ping in #cloud-init if you have questions.
Your team cloud init development team is requested to review the proposed merge of lp:~edouardb/cloud-init/scaleway-datasource into lp:cloud-init.