cloud-init-dev team mailing list archive

[Ryan Harper <ryan.harper@xxxxxxxxxxxxx>]

Diff comments:

> === modified file 'cloudinit/distros/rhel.py'
> --- cloudinit/distros/rhel.py	2015-06-02 20:27:57 +0000
> +++ cloudinit/distros/rhel.py	2016-06-14 17:59:09 +0000
> @@ -59,10 +61,16 @@
>          # should only happen say once per instance...)
>          self._runner = helpers.Runners(paths)
>          self.osfamily = 'redhat'
> +        self._net_renderer = sysconfig.Renderer()
>  
>      def install_packages(self, pkglist):
>          self.package_command('install', pkgs=pkglist)
>  
> +    def _write_network_config(self, netconfig):
> +        self._net_renderer.render_network_state(
> +            target="/", parse_net_config_data(netconfig))

Maybe more of a comment vs. the eni renderer, but it looks odd to me to see divergent set of parameters to the distro class _net_renderer.
Would we instead only take target and netconfig and require the parameters to be part of the netconfig/networkstate?

see cloudinit/distros/debian.py:Distro:_write_network_config(), as it takes networkstate and other params.

> +        return []
> +
>      def _write_network(self, settings):
>          # TODO(harlowja) fix this... since this is the ubuntu format
>          entries = net_util.translate_network(settings)


-- 
https://code.launchpad.net/~harlowja/cloud-init/cloud-init-net-sysconfig/+merge/297115
Your team cloud init development team is requested to review the proposed merge of lp:~harlowja/cloud-init/cloud-init-net-sysconfig into lp:cloud-init.