← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] lp:~sgolovatiuk/cloud-init/fix_no_server_cfg into lp:cloud-init


for this and the other mp at https://code.launchpad.net/~sgolovatiuk/cloud-init/fix_mcollective/+merge/298759

You will need to sign the CLA  http://www.ubuntu.com/legal/contributors (please feel free to ping me email or  irc if you have questions).

Second, can you add some unit tests for this?

Refactoring that code a bit would make it easy to have a unit test, and then we could easily ensure that it is functional in python2 and python3.

Your team cloud init development team is requested to review the proposed merge of lp:~sgolovatiuk/cloud-init/fix_no_server_cfg into lp:cloud-init.