← Back to team overview

cloud-init-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~smoser/cloud-init/trunk.mcollective-cleanup into lp:cloud-init

To: Scott Moser <smoser@xxxxxxxxxx>
From: Sergii Golovatiuk <sgolovatiuk@xxxxxxxxxxxx>
Date: Tue, 19 Jul 2016 14:35:51 -0000
In-reply-to: <20160718210255.1424.52365.launchpad@ackee.canonical.com>
Reply-to: mp+300394@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Refactoring looks good to me. It doesn't break anything. Also, Scott added more unit tests which is really good.
-- 
https://code.launchpad.net/~smoser/cloud-init/trunk.mcollective-cleanup/+merge/300394
Your team cloud init development team is requested to review the proposed merge of lp:~smoser/cloud-init/trunk.mcollective-cleanup into lp:cloud-init.