cloud-init-dev team mailing list archive

[Joshua Harlow <harlowja@xxxxxxxxx>]

Diff comments:

> diff --git a/cloudinit/sources/helpers/vmware/imc/config.py b/cloudinit/sources/helpers/vmware/imc/config.py
> index d645c49..a86233f 100644
> --- a/cloudinit/sources/helpers/vmware/imc/config.py
> +++ b/cloudinit/sources/helpers/vmware/imc/config.py
> @@ -93,3 +94,34 @@ class Config(object):
>              res.append(Nic(nic, self._configFile))
>  
>          return res
> +
> +    @property
> +    def admin_password(self):
> +        """Return the root password to be set."""
> +        return self._configFile.get(Config.PASS, None)
> +
> +    @property
> +    def reset_password(self):
> +        """Retreives if the root password needs to be reset."""
> +        resetPass = self._configFile.get(Config.RESETPASS, None)
> +        if resetPass and not re.match('yes$|no$', resetPass.lower()):
> +            raise ValueError("ResetPassword value should be yes/no")
> +        return resetPass
> +
> +    @property
> +    def marker_id(self):
> +        """Returns marker id."""
> +        return self._configFile.get(Config.MARKERID, None)
> +
> +    @property
> +    def GetPostGcStatus(self):

Let's not have properties start with 'get' and be in a mix of camel case and not. 

https://www.python.org/dev/peps/pep-0008/#prescriptive-naming-conventions

> +        """Retreives if customization status needs to be posted."""
> +        postGcStatus = self._configFile.get(Config.POST_GC, None)
> +        if postGcStatus and not re.match('yes$|no$', postGcStatus.lower()):
> +            raise ValueError("GC status value should be yes/no")
> +        return postGcStatus
> +
> +    @property
> +    def GetCustomScriptName(self):
> +        """Return the name of custom (pre/post) script."""
> +        return self._configFile.get(Config.CUSTOM_SCRIPT, None)


-- 
https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427
Your team cloud init development team is requested to review the proposed merge of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master.