cloud-init-dev team mailing list archive

Thread
Date

Re: [Merge] ~raharper/cloud-init:snapuser-create into cloud-init:master

To: mp+304700@xxxxxxxxxxxxxxxxxx
From: Scott Moser <smoser@xxxxxxxxxx>
Date: Wed, 19 Oct 2016 21:56:08 -0000
In-reply-to: <20160901205923.22097.424.launchpad@ackee.canonical.com>
Reply-to: mp+304700@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

over all, looks good.
you dont have to clean up the handle, but if you see easy way to do that that'd be nice.

is the snappy path now valid on non-snappy system ? (ubuntu server with 'snap' support).


lastly, please just review your commit message and make sure its up to date with all changes (it may well be, just think you made some changes since you wrote it).

-- 
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/304700
Your team cloud init development team is requested to review the proposed merge of ~raharper/cloud-init:snapuser-create into cloud-init:master.

References

[Merge] ~raharper/cloud-init:snapuser-create into cloud-init:master
From: Ryan Harper, 2016-09-01