cloud-init-dev team mailing list archive

[Martin Pitt <martin.pitt@xxxxxxxxxx>]

Review: Needs Information

LGTM, except for dropping local-fs.target; see inline comment.

Diff comments:

> diff --git a/systemd/cloud-init-local.service b/systemd/cloud-init-local.service
> index 55834ba..17e1391 100644
> --- a/systemd/cloud-init-local.service
> +++ b/systemd/cloud-init-local.service
> @@ -1,9 +1,7 @@
>  [Unit]
>  Description=Initial cloud-init job (pre-networking)
>  DefaultDependencies=no
> -Wants=local-fs.target

This is unnecessary anyway, so ok.

>  Wants=network-pre.target
> -After=local-fs.target

This is fine if you are absolutely sure that you don't need a writable root (otherwise you need After=systemd-remount-fs.service) and anything else writable (otherwise you need RequiresMountsFor=..., e. g. for /var/lib/cloud-init or similar).

>  Before=basic.target
>  Before=NetworkManager.service
>  Before=network-pre.target


-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/310547
Your team cloud init development team is requested to review the proposed merge of ~smoser/cloud-init:bug/1636912-systemd-cleanup into cloud-init:master.