cloud-init-dev team mailing list archive

Thread
Date

Re: [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

To: Joshua Powers <josh.powers@xxxxxxxxxxxxx>
From: Joshua Powers <josh.powers@xxxxxxxxxxxxx>
Date: Fri, 17 Mar 2017 16:29:00 -0000
In-reply-to: <20170314214033.10797.6904.launchpad@ackee.canonical.com>
Reply-to: mp+319878@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I added class/subclass method you proposed, which I like a lot. There is no reason for duplicate code. My only concern is base.py filling up with a bunch of code, but I think that is ok.

However, I had to modify the parameters slightly so nose actually realizes there are tests to run and added the __test__ = True variable. Both were required for tests to be discovered and ran; I did try without each. I also added the description change that we recently added to curtin since we are now doing this.

Here is output of a run with those two tests:
https://paste.ubuntu.com/24196020/
-- 
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319878
Your team cloud init development team is requested to review the proposed merge of ~powersj/cloud-init:test-set-password-list into cloud-init:master.