cloud-init-dev team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

Scott Moser has proposed merging ~smoser/cloud-init:bug/cleanup-prints-in-netplan-renderer into cloud-init:master.

Requested reviews:
  cloud init development team (cloud-init-dev)

For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/321465
-- 
Your team cloud init development team is requested to review the proposed merge of ~smoser/cloud-init:bug/cleanup-prints-in-netplan-renderer into cloud-init:master.

diff --git a/cloudinit/net/netplan.py b/cloudinit/net/netplan.py
index cd93b21..0a6178a 100644
--- a/cloudinit/net/netplan.py
+++ b/cloudinit/net/netplan.py
@@ -176,7 +176,6 @@ class Renderer(renderer.Renderer):
         # render from state
         content = self._render_content(network_state)
 
-        # ensure we poke udev to run net_setup_link
         if not header.endswith("\n"):
             header += "\n"
         util.write_file(fpnplan, header + content)
@@ -186,7 +185,7 @@ class Renderer(renderer.Renderer):
 
     def _netplan_generate(self, run=False):
         if not run:
-            print("netplan postcmd disabled")
+            LOG.debug("netplan_generate postcmd disabled")
             return
         util.subp(self.NETPLAN_GENERATE, capture=True)
 
@@ -196,17 +195,15 @@ class Renderer(renderer.Renderer):
            the setup_link udev builtin command
         """
         if not run:
-            print("netsetup postcmd disabled")
+            LOG.debug("net_setup_liink postcmd disabled")
             return
         setup_lnk = ['udevadm', 'test-builtin', 'net_setup_link']
         for cmd in [setup_lnk + [SYS_CLASS_NET + iface]
                     for iface in get_devicelist() if
                     os.path.islink(SYS_CLASS_NET + iface)]:
-            print(cmd)
             util.subp(cmd, capture=True)
 
     def _render_content(self, network_state):
-        print('rendering v2 for victory!')
         ethernets = {}
         wifis = {}
         bridges = {}