cloud-init-dev team mailing list archive

[Jon Grimm <jon.grimm@xxxxxxxxxxxxx>]

Cool feedback, and should be considered across the rest of the current
testcases (as I've lazily cut & pasted from current).    I'll address here
of course. :) Thanks!

On Fri, Mar 31, 2017 at 1:46 PM, Ryan Harper <ryan.harper@xxxxxxxxxxxxx>
wrote:

> Looks good!  Some feedback in the integration test.
>
> Diff comments:
>
> > diff --git a/tests/cloud_tests/configs/examples/install_run_chef_recipes.yaml
> b/tests/cloud_tests/configs/examples/install_run_chef_recipes.yaml
> > index 3cd28df..9b75d49 100644
> > --- a/tests/cloud_tests/configs/examples/install_run_chef_recipes.yaml
> > +++ b/tests/cloud_tests/configs/examples/install_run_chef_recipes.yaml
> > @@ -91,4 +95,9 @@ cloud_config: |
> >    # Useful for troubleshooting cloud-init issues
> >    output: {all: '| tee -a /var/log/cloud-init-output.log'}
> >
> > +collect_scripts:
> > +  chef_installed: |
> > +    #!/bin/bash
>
> The smoser in me says this should be /bin/sh.
>
> This looks like (below) attempting to confirm if the package is installed;
> I suggest using dpkg-query instead so we can verify the state of the
> package (dpkg -l may be rc, not ii);
>
> # not installed
> % dpkg-query -W -f '${Status}\n' chef
> dpkg-query: no packages found matching chef
>
> # installed
> % dpkg-query -W -f '${Status}\n' chef
> install ok installed
>
> > +    dpkg -l | grep chef | wc -l
> > +
> >  # vi: ts=4 expandtab
>
>
> --
> https://code.launchpad.net/~jgrimm/cloud-init/+git/cloud-
> init/+merge/321610
> You are the owner of ~jgrimm/cloud-init:fix_chef_example_source.
>



-- 
Jon Grimm
Engineering Manager, Ubuntu Server
Canonical Ltd

https://code.launchpad.net/~jgrimm/cloud-init/+git/cloud-init/+merge/321610
Your team cloud init development team is requested to review the proposed merge of ~jgrimm/cloud-init:fix_chef_example_source into cloud-init:master.