← Back to team overview

cloud-init-dev team mailing list archive

Thread
Date

Re: [Merge] ~smoser/cloud-init:bug/1674946-openstack-add-dvs into cloud-init:master

To: Scott Moser <smoser@xxxxxxxxxx>
From: Lars Kellogg-Stedman <lars@xxxxxxxxxx>
Date: Mon, 03 Apr 2017 14:27:53 -0000
In-reply-to: <20170403142250.22192.41361.launchpad@ackee.canonical.com>
Reply-to: mp+321709@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Seems fine to me, although I'm still in favor of just defaulting to something sane instead of throwing a ValueError for unknown link types.
-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/321709
Your team cloud init development team is requested to review the proposed merge of ~smoser/cloud-init:bug/1674946-openstack-add-dvs into cloud-init:master.

References

[Merge] ~smoser/cloud-init:bug/1674946-openstack-add-dvs into cloud-init:master
From: Scott Moser, 2017-04-03