cloud-init-dev team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

tiny nit


Diff comments:

> diff --git a/cloudinit/sources/helpers/digitalocean.py b/cloudinit/sources/helpers/digitalocean.py
> index 72f7bde..8d3d52a 100644
> --- a/cloudinit/sources/helpers/digitalocean.py
> +++ b/cloudinit/sources/helpers/digitalocean.py
> @@ -23,11 +23,8 @@ def assign_ipv4_link_local(nic=None):
>      """
>  
>      if not nic:
> -        for cdev in sorted(cloudnet.get_devicelist()):
> -            if cloudnet.is_physical(cdev):
> -                nic = cdev
> -                LOG.debug("assigned nic '%s' for link-local discovery", nic)
> -                break
> +        nic = get_link_local_nic()
> +        LOG.debug("selected interface '%s' for reading metadata" % nic)

s/ % /, /

LOG.debug("template %s", arg1)
is preferable to 
LOG.debug("template %s" % arg1)

>  
>      if not nic:
>          raise RuntimeError("unable to find interfaces to access the"


-- 
https://code.launchpad.net/~utlemming/cloud-init/+git/cloud-init-1/+merge/322397
Your team cloud init development team is requested to review the proposed merge of ~utlemming/cloud-init:lp-1676908-nic_selection_for_meta_data into cloud-init:master.