cloud-init-dev team mailing list archive

Thread
Date

Re: [Merge] ~jcastets/cloud-init:fix-net-cfg into cloud-init:master

To: Julien Castets <castets.j@xxxxxxxxx>
From: Scott Moser <smoser@xxxxxxxxxx>
Date: Tue, 16 May 2017 15:05:36 -0000
In-reply-to: <20170516144537.12189.54187.launchpad@ackee.canonical.com>
Reply-to: mp+324114@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

My only comments here is with respect to dhcp.
If the configuration type was dhcp, then i think its more correct to not include 'address', as most dhcp stanzas for network config are not going to have an address so that is at very least confusing.

How about this diff :
  http://paste.ubuntu.com/24587345/

-- 
https://code.launchpad.net/~jcastets/cloud-init/+git/cloud-init/+merge/324114
Your team cloud init development team is requested to review the proposed merge of ~jcastets/cloud-init:fix-net-cfg into cloud-init:master.

References

[Merge] ~jcastets/cloud-init:fix-net-cfg into cloud-init:master
From: Julien Castets, 2017-05-16