← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~smoser/cloud-init:bug/package-build-no-stylechecks into cloud-init:master

 

+1 passes CI, build test working again, all tox envs, except centos6, look good. Thanks for doing this.

The tox centos6 env, tested on centos 6 lxd, fail with the following, and I can get these cleaned up in a separate merge.

======================================================================
ERROR: Test read_user_data_callback() no files are found.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/cloud-init/tests/unittests/test_datasource/test_altcloud.py", line 422, in test_callback_none
    self.assertIsNone(dsac.read_user_data_callback(self.mount_dir))
AttributeError: 'TestReadUserDataCallback' object has no attribute 'assertIsNone'

======================================================================
FAIL: test_scripts_shebanged (tests.unittests.test_datasource.test_smartos.TestSmartOSDataSource)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/cloud-init/tests/unittests/test_datasource/test_smartos.py", line 465, in test_scripts_shebanged
    self.assertEqual(shebang, "#!/bin/bash")
AssertionError: '/bin/true' != '#!/bin/bash'
- /bin/true
+ #!/bin/bash

-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324541
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/package-build-no-stylechecks into cloud-init:master.


References