← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~ma-brothier/cloud-init:interfaces-order into cloud-init:master



This looks good.  Some comments... they're all minor, and should be explained more in HACKING.rst

a.) change description to be 
    <blank line>

b.) lets go ahead and just keep the function in a net/__init__.py rather than putting it in util.  And name it _natural_sort_key().  At some point if someone else needs such a function we can move it to util.

c.) a unit test would be good.  Just add something to tests/unittests/test_net.py to test your _natural_key_sort.  Also realize you can (and do) get interfaces named 'enp0s25' (as I have on this system).

d.) You'll need to sign the contributors agreement (see HACKING.rst).  Please feel free to ping me if you have any questions.

e.) Thanks!

d.) Thanks!
Your team cloud-init commiters is requested to review the proposed merge of ~ma-brothier/cloud-init:interfaces-order into cloud-init:master.