← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~smoser/cloud-init:feature/enable-aliyun into cloud-init:master


OK, So i thought some more, and with regard to the order of the two 'datasource_lists'.

Some points to think about
a.) If EC2's 'strict_id' is set to "warn" or "false", then the Ec2 datasource
will poll and time out very annoyingly.  "true" is the default setting in
trunk, but not yet in xenial.  historically, Ec2 was the first "polling"
datasource.  Any sources that did not positively identify themselves had to be
after Ec2 in the default list.  That was because "the early bird gets the
worm".  Basically in the event of cloud-init not having good information on
where it was running Ec2 got first dibs.

b.) the order in tools/ds-identify doesnt matter so much. 
Remember that this list is only consulted if there is no datasource_list declared in /etc/cloud/cloud.cfg or /etc/cloud/cloud.cfg.d/*.  So in that situation
the following matter:
 i.) if there were multiple datasources "DS_FOUND" (or DS_MAYBE), then they are placed into the list in the order of the DI_DSLIST_DEFAULT.  All DS_FOUND preceeed DS_MAYBE in such a list.
 ii.) if there are no DS_FOUND by ds-identify, and strict_id is false, then Ec2 would be return DS_MAYBE.  Having it first in that list means others after it would have to wait.

Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:feature/enable-aliyun into cloud-init:master.