cloud-init-dev team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

Scott Moser has proposed merging ~smoser/cloud-init:feature/net-convert-work-with-old into cloud-init:master.

Commit message:
tools/net-convert.py: support old cloudinit versions by using kwargs.

Older cloud-init versions have a bug in the signature of the
render_network_state method for netplan (bug 1685944).
The old had:
  render_network_state(target, network_state)
The correct is
  render_network_state(network_state, target)

This just changes our caller to use kwargs style when invoking that
method so that it works with either format.

Requested reviews:
  cloud-init commiters (cloud-init-dev)

For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324948
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:feature/net-convert-work-with-old into cloud-init:master.

diff --git a/tools/net-convert.py b/tools/net-convert.py
index b2db8ad..68559cb 100755
--- a/tools/net-convert.py
+++ b/tools/net-convert.py
@@ -75,7 +75,7 @@ def main():
         r_cls = sysconfig.Renderer
 
     r = r_cls()
-    r.render_network_state(ns, target=args.directory)
+    r.render_network_state(network_state=ns, target=args.directory)
 
 
 if __name__ == '__main__':