← Back to team overview

cloud-init-dev team mailing list archive

Thread
Date

Re: [Merge] ~smoser/cloud-init:feature/net-convert-work-with-old into cloud-init:master

To: Scott Moser <smoser@xxxxxxxxxx>
From: Chad Smith <chad.smith@xxxxxxxxxxxxx>
Date: Thu, 01 Jun 2017 14:50:56 -0000
In-reply-to: <20170601144346.6143.36685.launchpad@ackee.canonical.com>
Reply-to: mp+324948@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

+1 on explicit kwargs for extensibility of the call for future revs as well as handling the existing param re-ordering difference.
-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324948
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:feature/net-convert-work-with-old into cloud-init:master.

References

[Merge] ~smoser/cloud-init:feature/net-convert-work-with-old into cloud-init:master
From: Scott Moser, 2017-06-01