cloud-init-dev team mailing list archive

[Joshua Powers <josh.powers@xxxxxxxxxxxxx>]

Review: Approve

Ran on the test system and was back to under 20 seconds for each environment. Add link to bug (LP: 1714117), fix style tests, and this is good to go!

tests/unittests/test_datasource/test_ec2.py:6:1: F401 're' imported but unused
tests/unittests/test_datasource/test_ec2.py:203:24: E114 indentation is not a multiple of four (comment)
tests/unittests/test_datasource/test_ec2.py:207:24: E114 indentation is not a multiple of four (comment)
tests/unittests/test_datasource/test_ec2.py:208:24: E111 indentation is not a multiple of four


Diff comments:

> diff --git a/tests/unittests/test_datasource/test_ec2.py b/tests/unittests/test_datasource/test_ec2.py
> index e1ce644..5f920fd 100644
> --- a/tests/unittests/test_datasource/test_ec2.py
> +++ b/tests/unittests/test_datasource/test_ec2.py
> @@ -3,6 +3,7 @@
>  import copy
>  import httpretty
>  import mock
> +import re

not used?

>  
>  from .. import helpers as test_helpers
>  from cloudinit import helpers


-- 
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330040
Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:bug/ec2-tests-unmocked-metadata into cloud-init:master.