cloud-init-dev team mailing list archive
-
cloud-init-dev team
-
Mailing list archive
-
Message #03249
Re: [Merge] ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py b/tests/unittests/test_ds_identify.py
> index 1a81a89..c389029 100644
> --- a/tests/unittests/test_ds_identify.py
> +++ b/tests/unittests/test_ds_identify.py
> @@ -48,6 +54,7 @@ P_SEED_DIR = "var/lib/cloud/seed"
> P_DSID_CFG = "etc/cloud/ds-identify.cfg"
>
> MOCK_VIRT_IS_KVM = {'name': 'detect_virt', 'RET': 'kvm', 'ret': 0}
> +MOCK_UNAME_IS_PPC64 = {'name': 'uname', 'out': UNAME_PPC64EL, 'ret': 0}
why is there 'out' here vs. 'RET' in the other mock?
>
>
> class TestDsIdentify(CiTestCase):
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330242
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master.
Follow ups
References