cloud-init-dev team mailing list archive
-
cloud-init-dev team
-
Mailing list archive
-
Message #03274
Re: [Merge] ~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master
In commit message:
s/it's/its
I'd replace 'caches' metadata, to dumps; cache implies (to me) reuse but cloud-init doesn't use the json file at all (nor would it since it's already part of the cloud object).
Drop the 'Subsequent' sentence; while you may follow up with that it's not needed as part of the commit message.
Finally, question on the aborting if we have unserializable data; is it possible to skip/replace the binary data so we don't have an all-or-nothing situation?
Diff comments:
> diff --git a/cloudinit/sources/__init__.py b/cloudinit/sources/__init__.py
> index 9a43fbe..c08aa51 100644
> --- a/cloudinit/sources/__init__.py
> +++ b/cloudinit/sources/__init__.py
> @@ -10,6 +10,7 @@
>
> import abc
> import copy
> +import json
We already have util imported, would be nice to use a util.json_dumps() like the yaml_dumps() already in util. And I think you wrote one for unittest helpers; that could just be moved to util.
> import os
> import six
>
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330115
Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master.
References