cloud-init-dev team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

The proposal to merge ~smoser/cloud-init:bug/1715128-ec2-used-on-openstack into cloud-init:master has been updated.

Commit Message changed to:

Ec2: only attempt to operate at local mode on known platforms.

This change makes the DataSourceEc2Local do nothing unless it is on
actual AWS platform. The motivation is two fold:

a.) It is generally safer to only make this function available to Ec2
clones that explicitly identify themselves to the guest. (It also
gives them a reason to supply identification code to cloud-init.)

b.) On non-intel OpenStack platforms ds-identify would enable both the Ec2
and OpenStack sources. That is because there is not good data (such as
dmi) to positively identify the platform. Previously that would be fine
as OpenStack would run first and be successful. The change to add Ec2Local
meant that an Ec2 now runs first.

The best case for 'b' would be a slow down as attempts at the Ec2 metadata
service time out. The discovered case was worse.

LP: #1715128

For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330361
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/1715128-ec2-used-on-openstack into cloud-init:master.