← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~powersj/cloud-init:cii-kvm into cloud-init:master


Thanks for the reviews!

@chad.smith - It would be helpful to get your command line that you used where things failed or crashed.

For the record there are two design decisions that I want to clarify:

1) LXD still uses pylxd. I would like to change this over to mount-image-callback at some point, but not in this merge. As a result, there are a number of places that take advantage of pylxd operations giving a return code. This is passed around in numerous places. Using subprocess that is in cloud-init already does not have this feature, so I have to fake out the return code in a few places. With the move to MIC I will remove this entirely.

2) I prefer to pass string commands around in functions versus having arrays of strings. It is far easier to develop when modifying a string than an array of strings. It also makes far more sense to have a command as a string, as an array is not a command. The function doing the processing can run shlex.
Your team cloud-init commiters is requested to review the proposed merge of ~powersj/cloud-init:cii-kvm into cloud-init:master.