← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~chad.smith/cloud-init:ntp-schema into cloud-init:master

 


Diff comments:

> diff --git a/tests/cloud_tests/testcases/modules/ntp.yaml b/tests/cloud_tests/testcases/modules/ntp.yaml
> index fbef431..2530d72 100644
> --- a/tests/cloud_tests/testcases/modules/ntp.yaml
> +++ b/tests/cloud_tests/testcases/modules/ntp.yaml
> @@ -4,8 +4,8 @@
>  cloud_config: |
>    #cloud-config
>    ntp:
> -    pools: {}
> -    servers: {}

dict type is not valid schema for pools and servers which should be a list.

> +    pools: []
> +    servers: []
>  collect_scripts:
>    ntp_installed: |
>      #!/bin/bash


-- 
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/332540
Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:ntp-schema into cloud-init:master.


References