← Back to team overview

cloud-init-dev team mailing list archive

[Merge] ~rjschwei/cloud-init:noManualNet into cloud-init:master

 

Robert Schweikert has proposed merging ~rjschwei/cloud-init:noManualNet into cloud-init:master.

Requested reviews:
  cloud-init commiters (cloud-init-dev)

For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/334241

Related to 1733169

A network interface in a cloud environment should not be set to manual startmode. It is possible to receive data from the data source where a network interface may not be marked as "auto". This used to trigger the network configuration to set the startmode to manual. Manual startmode in a cloud environment may trigger loss of access to the VM if the only interface is not brought up at boot time. This fix addresses the problem by setting the startmode to "hotplug". Thus if the interface exists it will be started, even if it is not marked as "auto" in the data that describes the interface.
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~rjschwei/cloud-init:noManualNet into cloud-init:master.
diff --git a/cloudinit/distros/opensuse.py b/cloudinit/distros/opensuse.py
index a219e9f..e79aad2 100644
--- a/cloudinit/distros/opensuse.py
+++ b/cloudinit/distros/opensuse.py
@@ -179,7 +179,7 @@ class Distro(distros.Distro):
             if info.get('auto', None):
                 mode = 'auto'
             else:
-                mode = 'manual'
+                mode = 'hotplug'
             bootproto = info.get('bootproto', None)
             gateway = info.get('gateway', None)
             net_cfg = {

Follow ups