← Back to team overview

cloud-init-dev team mailing list archive

[Merge] ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master

 

Chad Smith has proposed merging ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master with ~james-hogarth/cloud-init:net-tools-deprecation as a prerequisite.

Commit message:
azure: Don't bounce network with ifdown ifup when those tools don't exist

This fixes a traceback when attempting to bounce the network after
hostname resets.

In artful and bionic ifupdown package is no longer installed in default
cloudimages.  As such, Azure can't use those tools to bounce the network
informing DDNS about hostname changes. This doesn't affect DDNS updates
though because systemd-networkd is now watching hostname deltas and with
default behavior to SendHostname=True over dhcp for all hostname updates
which publishes DDNS for us.

This branch also fixes two use-cases unhandled by the prerequisite branch:
  - In lxc's ip -o link list returns interface alias information such as
    eth0@if37 which needs to be truncated as we try to complete network
device information
  - In Azure, host target routes and gateways need to be handled

LP: #1722668

Requested reviews:
  cloud-init commiters (cloud-init-dev)
  Server Team CI bot (server-team-bot): continuous-integration

For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335468

azure: Don't bounce network with ifdown or ifup when those tools don't
exist

This fixes a traceback when attempting to bounce the network after
hostname resets.

In artful and bionic ifupdown package is no longer installed in
cloudimages.  As such, Azure can't use those tools to bounce the network
informing DDNS about hostname changes. This doesn't appear to affect DDNS
updates though because systemd-networkd is already watching hostname and
defaults to SendHostname=True during all dhcp upon hostname deltas which
posts updates to DDNS for us.

This branch also fixes two use-cases unhandled by the prerequisite branch:
  - In lxc's ip -o link list returns interface alias information such as
    eth0@if37 which needs to be truncated as we try to complete network
device information
  - In Azure, host target routes and gateways need to be handled

LP: #1722668
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master.