cloud-init-dev team mailing list archive

[Scott Moser <ssmoser2+ubuntu@xxxxxxxxx>]

The proposal to merge ~smoser/cloud-init:fix/subp-exception-with-bytes into cloud-init:master has been updated.

Commit Message changed to:

subp: make ProcessExecutionError have expected types in stderr, stdout.

When subp raised a ProcessExecutionError, that exception's stderr and
stdout might end up being the string '-' rather than bytes.

This mean that:
   try:
       subp(mycommand, decode=False)
   except ProcessExecutionError as e:
       pass

Would have 'e.stdout' set to '-' while the caller would expect bytes.

Also reduce the try/except block in subp to a specifically the two lines
that may raise an OSError.

For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336497
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/subp-exception-with-bytes into cloud-init:master.