← Back to team overview

cloud-init-dev team mailing list archive

[Merge] ~mgerdts/cloud-init:bug-1746605 into cloud-init:master

 

The proposal to merge ~mgerdts/cloud-init:bug-1746605 into cloud-init:master has been updated.

Commit Message changed to:

DataSourceSmartOS: add locking and retries

cloud-init and mdata-get each have their own implementation of the SmartOS
metadata protocol. If cloud-init and other services that call mdata-get
are run concurrently, crosstalk on the serial port can cause them both to
become confused.

This change makes it so that cloud-init uses the same cooperative locking
scheme that's used by mdata-get, thus preventing cross-talk between
mdata-get and cloud-init. To provide some level of protection against
others that may generate noise on the serial port, a retry mechanism is
also added.

For testing, pyserial is required. bddeb was changed to pass the proper
option to read-dependencies so that the renames in pkg-deps.json are
recognized.

LP: #1746605

For more details, see:
https://code.launchpad.net/~mgerdts/cloud-init/+git/cloud-init/+merge/337271
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~mgerdts/cloud-init:bug-1746605 into cloud-init:master.


References